search

conversejs / roundcube-plugin

XMPP plugin for Roundcube Webmail based on converse.js
Other
19 stars 8 forks source link

German localisation #1

Closed janmuennich closed 7 years ago

devurandom commented 7 years ago

Are you sure these are actually being used? I cannot find any reference to any of $labels' keys.

The second commit seems unnecessary, since jcbrand/converse.js#752 was already fixed.

janmuennich commented 7 years ago

Yes the localisation is for the configuration options in the Roundcube settings. They work for me like this.

Well, the second commit was made before the issue was closed. I could not know that jcbrand would be that quick 🥇 .

You don't have to pull that anyway. I just prefer to have all files delivered by the web server itself. Maybe an option in the configuration file would be nice for this.

devurandom commented 7 years ago

1a829b03f6e937b83648b0a12e8755f8c0cc0df8 was cherry-picked as d02d634d751e07869a711d1bbe0daa0cff49b6a7, because merging your branch was impossible, due to the unrelated changes.