search

conversejs / roundcube-plugin

XMPP plugin for Roundcube Webmail based on converse.js
Other
19 stars 8 forks source link

conflicts with elastic skin button message part, seems jquery issue pending #14

Closed mckaygerhard closed 1 year ago

mckaygerhard commented 2 years ago

i made that the plugin can work, the plugin loads.. but it has some issues with the butons of the messsages: it disapears

i upload a no jquery version build by me (i really dont know how to raised that .. i just do so fast and uglyway.. no interest right now) this is the first error, i guess i some kind of confflict with the version of the roundcube.. .. 

Uncaught Error: See almond README: incorrect module build, no module name
    define jQuery
    <anonymous> http://localhost/skins/elastic/deps/bootstrap.bundle.min.js?s=1655027994:6
    <anonymous> https://localhost/skins/elastic/deps/bootstrap.bundle.min.js?s=1655027994:6
converse.nojquery.min.js:212:2755

imagen

for the interest:

imagen

drlight17 commented 1 year ago

old version issue. closed.

mckaygerhard commented 1 year ago

ok solved with commit 5b14f73919439533985c6f7a8c15c8d365b3c5c0

drlight17 commented 1 year ago

ok solved with commit 5b14f73

also check this one https://github.com/conversejs/roundcube-plugin/pull/16/commits/4224bc51ec10a8652e15173fc9a03c82ef32857f