search

conversionfoundry / breeze

A Ruby on Rails CMS for brochure-style websites.
Other
3 stars 2 forks source link

Improvements to trees, namespacing for styles, version increment #162

Closed isaacfreeman closed 11 years ago

albandiguer commented 11 years ago

Hi Isaac,

Actually it is not ideal to ship the code that way. Bootstrap is a dependency so it's good to use a gem and only if we can't we embed it in vendor.

gem "twitter-bootstrap-rails", '= version' (= version important to avoid future surprise with bundle update)

isaacfreeman commented 11 years ago

On 25/01/2013, at 6:16 PM, Alban Diguer wrote:

Hi Isaac,

Actually it is not ideal to ship the code that way. Bootstrap is a dependency so it's good to use a gem and only if we can't we embed it in vendor.

gem "twitter-bootstrap-rails", '= version' (= version important to avoid future surprise with bundle update)

Good point. There was some reason why I didn't use this in the first place, but I can't remember what it was and it probably doesn't matter any more. I'll make the change, and the Bootstrap gem can be a dependency for both Breeze and Breeze Commerce, which will decrease coupling.

Isaac Freeman | Developer | LeftClick Tel: +64 3 940 1391 | Skype: isaacfreeman | Web: www.leftclick.com

Christchurch Head Office: EPIC Innovation Centre, 78-106 Manchester Street, Christchurch, New Zealand Auckland Sales Office: Level 31 Vero Centre, 48 Shortland Street, Auckland, New Zealand