conversionxl / aybolit

Lightweight web components library built with LitElement.
https://conversionxl.github.io/aybolit/
MIT License
7 stars 8 forks source link

feat: bring gravity forms styes and add gravity form story #200

Closed anoblet closed 2 years ago

anoblet commented 2 years ago

This adds a gravity form story with an optional pending state.

github-actions[bot] commented 2 years ago

size-limit report 📦

Path Size
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js, packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js, packages/cxl-ui/pkg/dist-web/cxl-ui.js 59.77 KB (0%)
lkraav commented 2 years ago

Story should be a support element for an actual implementation of something.

We're looking to get a central style asset that the story can use.

I think we want to model it to live at somewhere like https://github.com/conversionxl/aybolit/tree/master/packages/cxl-lumo-styles/scss/gravityforms.scss?

lkraav commented 2 years ago

For reference, stuff we've found enough reason to override previously:

https://github.com/conversionxl/wp-theme-lib/blob/master/scss/legacy/_70-gravityforms.scss

If anything, that's the stuff to be considered for migration to Aybolit layer. Each rule will need to be identified for sanity, and HTML state mocked in a story.

anoblet commented 2 years ago

@saas786 Is there anything else we should be adding?

kylebrodeur commented 2 years ago

Task linked: CU-2c1y7zk Migrate GForm styles from wp-theme-lib to aybolit

saas786 commented 2 years ago

@anoblet please create a separate PR for https://app.clickup.com/t/232pth1

Keep current PR open just move this code:

https://github.com/conversionxl/aybolit/blob/373ad669f802fb07e1f6a1acd7dce9153e3c5dec/packages/cxl-lumo-styles/scss/gravity-forms.scss#L23

to new PR.

lkraav commented 2 years ago

It's OK to hold off on this until I have some time to look into details.

pawelkmpt commented 2 years ago

@anoblet should Gravity Form tab on the left show anything? It's blank screen for me

saas786 commented 2 years ago

@anoblet should Gravity Form tab on the left show anything? It's blank screen for me

@anoblet somehow it still shows [unresolved]

chrome_N3EkyXhjhS

anoblet commented 2 years ago

@pawelkmpt @saas786

It seems to be coming from this line: https://github.com/conversionxl/aybolit/blob/f88d7a396f66549c92115a531480e6a7a497ca82/packages/cxl-lumo-styles/scss/loading.css#L46-L49

I need to take a look at why [unresolved] is still targeted.

anoblet commented 2 years ago

I'm not sure we should be loading loading.css here: https://github.com/conversionxl/aybolit/pull/200/commits/30e8c993eebc1151a70faf0e19d1b31aa67d6b6b

pawelkmpt commented 2 years ago

Should it have spinner?

Screenshot 2022-10-21 at 15 34 17

anoblet commented 2 years ago

@pawelkmpt

I was asked to separate the spinner into a separate PR: https://github.com/conversionxl/aybolit/pull/200#issuecomment-1127526597

Here is the PR for the spinner: https://github.com/conversionxl/aybolit/pull/226

pawelkmpt commented 2 years ago

I was asked to separate the spinner into a separate PR: #200 (comment)

Weird but OK.

Here is the PR for the spinner: #226

It does not load, similar to what we had here.

saas786 commented 2 years ago

Here is the PR for the spinner: #226

It does not load, similar to what we had here.

@anoblet

It should work in #226, separation doesn't mean it should not work.

anoblet commented 2 years ago

@pawelkmpt @saas786

226 Had the same loading.css import. I removed it.

pawelkmpt commented 2 years ago

Once done I can make a release together with already merged #230

anoblet commented 2 years ago

@pawelkmpt Squashed