search

conversionxl / aybolit

Lightweight web components library built with LitElement.
https://conversionxl.github.io/aybolit/
MIT License
7 stars 8 forks source link

Possible patches, refactoring and maybe cleanup. #208

Closed saas786 closed 2 years ago

github-actions[bot] commented 2 years ago

size-limit report 📦

Path Size
packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js, packages/cxl-ui/pkg/dist-web/cxl-ui.js 41.75 KB (0%)
kylebrodeur commented 2 years ago

Task linked: CU-2xw2h8u Aybolit review / testing / patches after playbooks -> master merge

anoblet commented 2 years ago

What happened to the story from https://github.com/conversionxl/aybolit/pull/198?

I picked up on the error a couple of weeks ago: https://github.com/conversionxl/aybolit/pull/202#discussion_r841630764.

It looks like CXLPlaybookAccordion supports a named object argument. Using it would help future-proof things.

https://github.com/conversionxl/aybolit/blob/476764d8fcb147e69b7324563e3f0d64153b476c/packages/storybook/cxl-ui/cxl-vaadin-accordion/cxl-playbook-accordion.story.js#L5

saas786 commented 2 years ago

What happened to the story from https://github.com/conversionxl/aybolit/pull/198?

This has been moved to new general story: https://github.com/conversionxl/aybolit/commit/675f29b71d87c7ee70a2c129b5c7e28524c1d25d

I picked up on the error a couple of weeks ago: https://github.com/conversionxl/aybolit/pull/202#discussion_r841630764. It looks like CXLPlaybookAccordion supports a named object argument. Using it would help future-proof things.

Thanks, I missed it, too many components to look for, PRs etc. Updated the code, should be fine now.