search

conversionxl / aybolit

Lightweight web components library built with LitElement.
https://conversionxl.github.io/aybolit/
MIT License
7 stars 8 forks source link

anoblet/fix/storybook-definition #209

Closed anoblet closed 2 years ago

anoblet commented 2 years ago

When syncing with master I'm running into this error:

localhost_6006_

As opposed to React, Web Components don't use the component field (https://storybook.js.org/docs/web-components/writing-stories/introduction).

The field can either be omitted or set to a string.

github-actions[bot] commented 2 years ago

size-limit report 📦

Path Size
packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js, packages/cxl-ui/pkg/dist-web/cxl-ui.js 41.75 KB (0%)
pawelkmpt commented 2 years ago

How components are imported now when you removed import line?

anoblet commented 2 years ago

@pawelkmpt You're right :)

I'm not sure why the stories still load correctly. I added back the import statements without loading the specific classes.

Edit:

I figured out why they are still loaded: https://lit-and-friends.slack.com/archives/C03PF4L4L/p1654174953792729?thread_ts=1654174050.408669&cid=C03PF4L4L