conversionxl / aybolit

Lightweight web components library built with LitElement.
https://conversionxl.github.io/aybolit/
MIT License
7 stars 8 forks source link

Playbook progress bar doesn't work in story: CXL-UI > Paywall > Layout #212

Closed saas786 closed 2 years ago

saas786 commented 2 years ago

Doesn't work: https://www.loom.com/share/c5e8a333ef9849ab93d1e373137de73f

Used to work: https://www.loom.com/share/ee98dd45b28f422f8926ac7b4d635058


I have tested it with: Before playbooks to master merge: https://github.com/conversionxl/aybolit/commit/7e63abf38a4681000e60fd6303de15dd4cb98911 After & current master: https://github.com/conversionxl/aybolit/commit/6ee74721ca73174739d41dfbb16bbb75093c0d45 So its only happening in Lit upgrade branch: https://github.com/conversionxl/aybolit/tree/anoblet/feat/lit


Related PR: https://github.com/conversionxl/aybolit/pull/211


Updated:

Its not working in CXL-UI > Paywall > Layout. So we need to update or sync this story with CXL-UI > cxl-app-layout > [layout=2c-l]

saas786 commented 2 years ago

Pulled https://github.com/conversionxl/aybolit/commits/anoblet/feat/lit just now.

Seems like working.

So confused now :)

@anoblet

anoblet commented 2 years ago

I believe you are looking at two different stories:

1) CXL-UI > cxl-app-layout > [layout=2c-l] 2) CXL-UI > Paywall > Layout

When I wrote the paywall story, I copied the layout story. The progress bar was static at that time. At a later date the layout story was updated, those updates didn't carry over to the paywall story.

The paywall story should be updated, though the issue shouldn't be related to the lit migration.

saas786 commented 2 years ago

The paywall story should be updated, though the issue shouldn't be related to the lit migration.

Verified, you are correct. I was mixing both. I will update the issue description accordingly.

saas786 commented 2 years ago

Its not working as intended in #213

For both:

CXL-UI > cxl-app-layout > [layout=2c-l] CXL-UI > Paywall > Layout

saas786 commented 2 years ago

fixed in: https://github.com/conversionxl/aybolit/commit/cbe266e1f721b551b62b0e1c79b5abaa0e78b4bf