feat(cxl-ui): [cxl-marketing-nav] add descriptions

conversionxl / aybolit

Lightweight web components library built with LitElement.

https://conversionxl.github.io/aybolit/

MIT License

7 stars 8 forks source link

feat(cxl-ui): [cxl-marketing-nav] add descriptions #220

Closed saas786 closed 2 years ago

saas786 commented 2 years ago

Closed old PRs:

and created fresh branch & PR by bringing the changes from above PRs.

kylebrodeur commented 2 years ago

Task linked: CU-2x7c7dv Aybolit - Nav Menu items description feature.

github-actions[bot] commented 2 years ago

size-limit report 📦

Path	Size
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js, packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js, packages/cxl-ui/pkg/dist-web/cxl-ui.js	58.9 KB (+0.47% 🔺)

saas786 commented 2 years ago

@anoblet

Which menu should show description, I had a look at My Dashboard but it doesn't seem to show description.

Ref: https://deploy-preview-220--conversionxl-aybolit.netlify.app/?path=/story/cxl-ui-cxl-marketing-nav--cxl-marketing-nav

anoblet commented 2 years ago

@saas786

It seems Vaadin got rid of contextMenu.render(), I updated it to contextMenu.requestContentUpdate(). You should now be able to see a description under My Dashboard.