search

conversionxl / aybolit

Lightweight web components library built with LitElement.
https://conversionxl.github.io/aybolit/
MIT License
7 stars 8 forks source link

remove obsolete @cwmr/iron-star-rating dependency #240

Closed anoblet closed 1 year ago

anoblet commented 1 year ago

https://github.com/conversionxl/aybolit/pull/237#issuecomment-1330448020

github-actions[bot] commented 1 year ago

size-limit report 📦

Path Size
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js, packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js, packages/cxl-ui/pkg/dist-web/cxl-ui.js 65.7 KB (0%)
saas786 commented 1 year ago

@anoblet

yarn.lock missing.

anoblet commented 1 year ago

@saas786 Fixed

saas786 commented 1 year ago

@saas786 Fixed

Incorrect yarn.lock file, should be like this: yarn.lock

Yours have other changes too, should only contain removal changes.

anoblet commented 1 year ago

I usually remove yarn.lock and run yarn install. I guess this doesn't give us the best picture for package versions. I re-ran without removing yarn.lock.

saas786 commented 1 year ago

I usually remove yarn.lock and run yarn install. I guess this doesn't give us the best picture for package versions. I re-ran without removing yarn.lock.

:) yeah, if we are maintaining it via GH, need to do it on existing yarn.lock, creating new yarn.lock changes it a whole lot, bring updated packages and what not.

lkraav commented 1 year ago

Completed in #237