search

conversionxl / aybolit

Lightweight web components library built with LitElement.
https://conversionxl.github.io/aybolit/
MIT License
7 stars 8 forks source link

fix(cxl-ui): [cxl-jw-player] track separation issue #246

Open anoblet opened 1 year ago

anoblet commented 1 year ago

When a user goes to copy and paste a transcript, tracks are not separated properly. Instead of using padding to separate the tracks, we should use a space allowing the user to copy and paste the transcript and have it be formatted correctly

anoblet commented 1 year ago

@saas786 I don't want to disrupt your progress.

There was some discussion with Kyle about rendering the transcript server-side, though this was never settled. If we do decide to grab it client-side, we need to figure out how to use spaces vs. padding here:

https://github.com/conversionxl/aybolit/blob/22fa914efb97c6b25e22ad79e6d511c774d89cbd/packages/cxl-ui/src/components/cxl-jw-player/index.html.js#L38

saas786 commented 1 year ago

@saas786 I don't want to disrupt your progress.

There was some discussion with Kyle about rendering the transcript server-side, though this was never settled. If we do decide to grab it client-side, we need to figure out how to use spaces vs. padding here:

https://github.com/conversionxl/aybolit/blob/22fa914efb97c6b25e22ad79e6d511c774d89cbd/packages/cxl-ui/src/components/cxl-jw-player/index.html.js#L38

@anoblet

I am no longer a part of CXL.

cc @lkraav @pawelkmpt