conversionxl / aybolit

Lightweight web components library built with LitElement.
https://conversionxl.github.io/aybolit/
MIT License
7 stars 8 forks source link

feat(cxl-ui): [cxl-vaadin-accordion] update mobile behavior #256

Open anoblet opened 1 year ago

anoblet commented 1 year ago

https://app.clickup.com/t/86773vpgj

When on mobile:

1) Disable save panel state 2) Open all panels 3) Disable open/close events

github-actions[bot] commented 1 year ago

size-limit report 📦

Path Size
packages/cxl-ui/pkg/dist-web/cxl-ui.js 30.97 KB (+0.63% 🔺)
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js 11.87 KB (0%)
packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js 23.46 KB (0%)
packages/cxl-ui/pkg/dist-web/vendor.js 122.56 KB (0%)
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js, packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js, packages/cxl-ui/pkg/dist-web/cxl-ui.js, packages/cxl-ui/pkg/dist-web/manifest.js, packages/cxl-ui/pkg/dist-web/unresolved.js, packages/cxl-ui/pkg/dist-web/vendor.js 190.03 KB (+0.11% 🔺)
lkraav commented 1 year ago

CU task? Totally unclear what this PR tries to do.

anoblet commented 1 year ago

@lkraav Added CU link and description.

lkraav commented 1 year ago

OK this is way too much complicated code for what it's trying to accomplish :thinking:

anoblet commented 1 year ago

https://www.loom.com/share/e08111d527b743d783743d97215f030b

anoblet commented 1 year ago

@lkraav What if we run the logic on first render rather than watching for device width changes?