conversionxl / aybolit

Lightweight web components library built with LitElement.
https://conversionxl.github.io/aybolit/
MIT License
7 stars 8 forks source link

refactor(cxl-lumo-styles): unwrap lets app use large screen estate #259

Closed lkraav closed 1 year ago

lkraav commented 1 year ago

Re-orient from --cxl-wrap-width to --cxl-content-max-width, communicates intent clearer.

Will probably require some refactor in app CSS.

1080p BEFORE image

1080p AFTER image

github-actions[bot] commented 1 year ago

size-limit report 📦

Path Size
packages/cxl-ui/pkg/dist-web/cxl-ui.js 36.28 KB (+0.06% 🔺)
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js 11.87 KB (0%)
packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js 25.44 KB (+0.01% 🔺)
packages/cxl-ui/pkg/dist-web/vendor.js 133.84 KB (0%)
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js, packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js, packages/cxl-ui/pkg/dist-web/cxl-ui.js, packages/cxl-ui/pkg/dist-web/manifest.js, packages/cxl-ui/pkg/dist-web/unresolved.js, packages/cxl-ui/pkg/dist-web/vendor.js 208.59 KB (+0.01% 🔺)
pawelkmpt commented 1 year ago

@anoblet I used this branch on localhost, checked few pages and they look good in general. Besides the dashboard. Cards are suddenly full-width. Could you check why?

Screenshot 2023-07-26 at 10 47 30
pawelkmpt commented 1 year ago

@anoblet I used this branch on localhost, checked few pages and they look good in general. Besides the dashboard. Cards are suddenly full-width. Could you check why?

I was missing https://github.com/conversionxl/cxl-wpstarter/pull/142 branch active.