Open anoblet opened 1 year ago
Path | Size |
---|---|
packages/cxl-ui/pkg/dist-web/cxl-ui.js | 33.58 KB (+0.03% 🔺) |
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js | 11.87 KB (0%) |
packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js | 24.9 KB (0%) |
packages/cxl-ui/pkg/dist-web/vendor.js | 125.6 KB (0%) |
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js, packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js, packages/cxl-ui/pkg/dist-web/cxl-ui.js, packages/cxl-ui/pkg/dist-web/manifest.js, packages/cxl-ui/pkg/dist-web/unresolved.js, packages/cxl-ui/pkg/dist-web/vendor.js | 197.11 KB (+0.01% 🔺) |
Thanks. It's difficult to tell for QA where to look for before / after states. Can you edit PR opener with screenshots?
@lkraav I'm not sure why, though I'm not able to replicate in Storybook. In Storybook bottom
is not being set on the overlay. When I set bottom after the fact in dev tools for Institute to var(--lumo-space-m)
on the overlay, the proper height is achieved.
This isn't ideal, though I'm not sure how to replicate this in Storybook.
This isn't ideal, though I'm not sure how to replicate this in Storybook.
Maybe it's some race condition, and not a safe solution?
Still, intended result before / after screenshots are needed for reviewers to evaluate anything, even if "after" is with manual inspector modding right now.
I added screenshots earlier, though didn't click update comment :/
They should be there now.
I added screenshots earlier, though didn't click update comment :/ They should be there now.
Hmm, but this is on live server? Was looking for ability to QA solutions in Storybook.
I'm not able to replicate in Storybook :/
Discussion: https://cxlworld.slack.com/archives/C01HNLQNVA9/p1683877197950619
Before:
After: