feat: add dashboard category accordion

conversionxl / aybolit

Lightweight web components library built with LitElement.

https://conversionxl.github.io/aybolit/

MIT License

7 stars 8 forks source link

feat: add dashboard category accordion #288

Closed kertuilves closed 1 year ago

kertuilves commented 1 year ago

https://app.clickup.com/t/861n0qkvd

Dependencies:

github-actions[bot] commented 1 year ago

size-limit report 📦

Path	Size
packages/cxl-ui/pkg/dist-web/cxl-ui.js	34.59 KB (+1.94% 🔺)
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js	11.87 KB (0%)
packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js	25.68 KB (+1.57% 🔺)
packages/cxl-ui/pkg/dist-web/vendor.js	125.6 KB (0%)
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js, packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js, packages/cxl-ui/pkg/dist-web/cxl-ui.js, packages/cxl-ui/pkg/dist-web/manifest.js, packages/cxl-ui/pkg/dist-web/unresolved.js, packages/cxl-ui/pkg/dist-web/vendor.js	198.9 KB (+0.54% 🔺)

heshfekry commented 1 year ago

Hey @kertuilves

The progress bar is missing from the sub section.

Except for that great job on the component both on desktop and mobile i didn't see anything immediately in UX.

heshfekry commented 1 year ago

A little bit of padding on the horizontal scroll indicator perhaps.

pawelkmpt commented 1 year ago

A little bit of padding on the horizontal scroll indicator perhaps.

Design does not have scrollbar. Maybe we'd like to hide it @heshfekry ?

heshfekry commented 1 year ago

@pawelkmpt hide works too. Netflix design also does not have it which is what its based of off.

pawelkmpt commented 1 year ago

Is #289 dependency for this PR? Should we commit lightweight card so you can use here?

kertuilves commented 1 year ago

Is #289 dependency for this PR? Should we commit lightweight card so you can use here?

I didn't see it would be necessary because it would just change the card content and it doesn't affect the layout. But if it's something that should be done I'm up for it and will do the changes.