Closed HenerHoop closed 11 months ago
Path | Size |
---|---|
packages/cxl-ui/pkg/dist-web/cxl-ui.js | 34.03 KB (+0.27% 🔺) |
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js | 11.87 KB (0%) |
packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js | 25.39 KB (+0.41% 🔺) |
packages/cxl-ui/pkg/dist-web/vendor.js | 125.6 KB (0%) |
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js, packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js, packages/cxl-ui/pkg/dist-web/cxl-ui.js, packages/cxl-ui/pkg/dist-web/manifest.js, packages/cxl-ui/pkg/dist-web/unresolved.js, packages/cxl-ui/pkg/dist-web/vendor.js | 198.04 KB (+0.1% 🔺) |
@HenerHoop can I do in-deep review comparing to the design or you'll push some changes soon?
@pawelkmpt I'll push some changes soon.
@pawelkmpt I accidentally pushed a few extra lines as well. You can now take another look.
@pawelkmpt I accidentally pushed a few extra lines as well. You can now take another look.
it's better now 👍
Could not find a way to change the box shadow on vaadin-context-menu-list-box elements
It is working nice now, good job
On mobile hovering on the item with descendants opens submenu. It doesn't work like that in other places. Need fixes
@freudFlintstone let me show on examples what I mean by possibility to have menu section header WITHOUT a link/being a
component.
Following params passed. URL is empty string.
$menu_item['component'] = 'a';
$menu_item['description'] = $item->description;
$menu_item['href'] = $item->url;
$menu_item['sectionheader'] = true;
Result: Deep skills links to the current URL -> ❌ wrong
Following params passed. No href
item.
$menu_item['component'] = 'a';
$menu_item['description'] = $item->description;
$menu_item['sectionheader'] = true;
Result: Deep skills link is undefined
-> ❌ wrong
Following params passed. It's section header and component not defined.
$menu_item['description'] = $item->description;
$menu_item['sectionheader'] = true;
Result: Deep skills has not background and no description -> ❌ wrong
What I expect from section header item:
href
is not empty.Please provide such tweak and tell me what params I shall pass to JS in order to make it work.
Context menu items are positioned differently for logged in and guest users. Possible reason: logged in users see admin bar at the top and JS doesn't take it into account.
✅ CORRECT for guests
❌ INCORRECT for logged in users
Could not find a way to change the box shadow on vaadin-context-menu-list-box elements
https://app.clickup.com/t/861mx0nwm
https://www.figma.com/file/RTj2PtUSrCOUFtljOiq0W3/Dashboard?type=design&node-id=291-78069&mode=design