conversionxl / aybolit

Lightweight web components library built with LitElement.
https://conversionxl.github.io/aybolit/
MIT License
7 stars 8 forks source link

feat: update navigation #290

Closed HenerHoop closed 11 months ago

HenerHoop commented 1 year ago

Could not find a way to change the box shadow on vaadin-context-menu-list-box elements

https://app.clickup.com/t/861mx0nwm

https://www.figma.com/file/RTj2PtUSrCOUFtljOiq0W3/Dashboard?type=design&node-id=291-78069&mode=design

github-actions[bot] commented 1 year ago

size-limit report 📦

Path Size
packages/cxl-ui/pkg/dist-web/cxl-ui.js 34.03 KB (+0.27% 🔺)
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js 11.87 KB (0%)
packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js 25.39 KB (+0.41% 🔺)
packages/cxl-ui/pkg/dist-web/vendor.js 125.6 KB (0%)
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js, packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js, packages/cxl-ui/pkg/dist-web/cxl-ui.js, packages/cxl-ui/pkg/dist-web/manifest.js, packages/cxl-ui/pkg/dist-web/unresolved.js, packages/cxl-ui/pkg/dist-web/vendor.js 198.04 KB (+0.1% 🔺)
pawelkmpt commented 1 year ago

@HenerHoop can I do in-deep review comparing to the design or you'll push some changes soon?

HenerHoop commented 1 year ago

@pawelkmpt I'll push some changes soon.

HenerHoop commented 1 year ago

@pawelkmpt I accidentally pushed a few extra lines as well. You can now take another look.

pawelkmpt commented 1 year ago

@pawelkmpt I accidentally pushed a few extra lines as well. You can now take another look.

it's better now 👍

pawelkmpt commented 1 year ago

Could not find a way to change the box shadow on vaadin-context-menu-list-box elements

It is working nice now, good job

pawelkmpt commented 1 year ago

On mobile hovering on the item with descendants opens submenu. It doesn't work like that in other places. Need fixes

pawelkmpt commented 11 months ago

@freudFlintstone let me show on examples what I mean by possibility to have menu section header WITHOUT a link/being a component.

CASE 1

Following params passed. URL is empty string.

$menu_item['component']     = 'a';
$menu_item['description']   = $item->description;
$menu_item['href']          = $item->url;
$menu_item['sectionheader'] = true;

Result: Deep skills links to the current URL -> ❌ wrong

Screenshot 2023-08-29 at 10 25 06


CASE 2

Following params passed. No href item.

$menu_item['component']     = 'a';
$menu_item['description']   = $item->description;
$menu_item['sectionheader'] = true;

Result: Deep skills link is undefined -> ❌ wrong

Screenshot 2023-08-29 at 10 24 44


CASE 3

Following params passed. It's section header and component not defined.

$menu_item['description']   = $item->description;
$menu_item['sectionheader'] = true;

Result: Deep skills has not background and no description -> ❌ wrong

Screenshot 2023-08-29 at 10 31 00


What I expect from section header item:

Please provide such tweak and tell me what params I shall pass to JS in order to make it work.

pawelkmpt commented 11 months ago

Bug

Context menu items are positioned differently for logged in and guest users. Possible reason: logged in users see admin bar at the top and JS doesn't take it into account.

✅ CORRECT for guests

Screenshot 2023-08-29 at 10 35 36

❌ INCORRECT for logged in users

Screenshot 2023-08-29 at 10 35 24