search

conversionxl / aybolit

Lightweight web components library built with LitElement.
https://conversionxl.github.io/aybolit/
MIT License
7 stars 8 forks source link

feat(cxl-ui): add institute page filtering components #296

Closed freudFlintstone closed 1 year ago

freudFlintstone commented 1 year ago

Task: https://app.clickup.com/t/861mzgnx5

Dependencies: https://github.com/conversionxl/aybolit/pull/293

freudFlintstone commented 1 year ago

These changes depend on being able to replace some of the elements rendered by the FacetWP plugin. Here's a gist for a similar problem: https://gist.github.com/MWDelaney/7f3ff797041bac5ef9918112d6a43816

pawelkmpt commented 1 year ago

@freudFlintstone start over and created new branch from feat/dashboard not master. Otherwise we'll get into bunch of conflicts.

freudFlintstone commented 1 year ago

@pawelkmpt But it was branched from feat/dashboard: https://github.com/conversionxl/aybolit/network Maybe the problem is that I rebased my local feat/dashboard on master, like we talked about here I'll just pull feat/dashboard again and reapply these changes

Screenshot from 2023-07-14 08-01-17

pawelkmpt commented 1 year ago

Maybe the problem is that I rebased my local feat/dashboard on master, like we talked about here I'll just pull feat/dashboard again and reapply these changes

It should've been pushed then. I've tried that ITMW but noticed other PRs which started from feat/dashboard get conflicts.

freudFlintstone commented 1 year ago

I tried pushing and had an issue too. The cards PR has a similar problem. Should I fix feat/dashboard and everyone can rebase after, or just start this one over?

pawelkmpt commented 1 year ago

I tried pushing and had an issue too. The cards PR has a similar problem. Should I fix feat/dashboard and everyone can rebase after, or just start this one over?

Just start this one over. I'll rebase feat/dashboard later. master doesn't have any critical updates needed for dashboard work