conversionxl / aybolit

Lightweight web components library built with LitElement.
https://conversionxl.github.io/aybolit/
MIT License
7 stars 8 forks source link

feat(cxl-ui): add `cxl-search-filters` and related components #297

Open freudFlintstone opened 1 year ago

freudFlintstone commented 1 year ago

Task: https://app.clickup.com/t/861mzgnx5

These changes depend on being able to replace some of the elements rendered by the FacetWP plugin. Here's a gist for a similar problem: https://gist.github.com/MWDelaney/7f3ff797041bac5ef9918112d6a43816

freudFlintstone commented 1 year ago

A few notes:

pawelkmpt commented 1 year ago

For easier review but also tracking code it'd be better to have every component as separate commit.

freudFlintstone commented 1 year ago

For easier review but also tracking code it'd be better to have every component as separate commit.

Do you want me to go back and make separate commits? It's doable

pawelkmpt commented 1 year ago

For easier review but also tracking code it'd be better to have every component as separate commit.

Do you want me to go back and make separate commits? It's doable

Yes, please

anoblet commented 1 year ago

Would it make sense to default the first tab to selected?

image

freudFlintstone commented 1 year ago

Would it make sense to default the first tab to selected?

image

Yes. I'll update the story to correctly depict that intention, but it really depends on how FacetWP sets the default on the back-end.