search

conversionxl / aybolit

Lightweight web components library built with LitElement.
https://conversionxl.github.io/aybolit/
MIT License
7 stars 8 forks source link

feat(cxl-ui): add cxl-dashboard-notification component #301

Closed kertuilves closed 1 year ago

kertuilves commented 1 year ago

https://app.clickup.com/t/861n0qm2v

kertuilves commented 1 year ago

This is looking good in general.

For me hover state is missing. From Figma design I understood black background is the one but your implementation shows it's used for category notifications. I asked Janeli and @heshfekry about it.

I talked to Mathias about it, Janeli mentioned that he was the one who designed it. And he mentioned that different course types (video, category, training, playbook and etc) will have different bg colors like in a course-card component. But as I understood they aren't all defined yet and so I implemented only the one that was seen in the Figma.

heshfekry commented 1 year ago

What happens with clearing notifications or is that not defined in the design?

kertuilves commented 1 year ago

What happens with clearing notifications or is that not defined in the design?

The notifications will be in the "Other" category. This is like a "Read" section.