conversionxl / aybolit

Lightweight web components library built with LitElement.
https://conversionxl.github.io/aybolit/
MIT License
7 stars 8 forks source link

fix(cxl-ui): add dashboard accordion new styles #314

Closed kertuilves closed 11 months ago

kertuilves commented 11 months ago

https://app.clickup.com/t/86ay6gc3z

github-actions[bot] commented 11 months ago

size-limit report 📦

Path Size
packages/cxl-ui/pkg/dist-web/cxl-ui.js 62.64 KB (+0.17% 🔺)
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js 11.87 KB (0%)
packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js 27.43 KB (-0.02% 🔽)
packages/cxl-ui/pkg/dist-web/vendor.js 135.58 KB (0%)
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js, packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js, packages/cxl-ui/pkg/dist-web/cxl-ui.js, packages/cxl-ui/pkg/dist-web/manifest.js, packages/cxl-ui/pkg/dist-web/unresolved.js, packages/cxl-ui/pkg/dist-web/vendor.js 238.67 KB (+0.05% 🔺)
pawelkmpt commented 11 months ago

Design doesn't have indents on every level

Screenshot 2023-09-06 at 14 40 37

kertuilves commented 11 months ago

@heshfekry @pawelkmpt When I saw that the design that was under task description was missing from Figma I asked Janeli about it. She said that @heshfekry picked after our meeting this new design. Is this correct information?

Screenshot 2023-09-06 at 15 45 46
heshfekry commented 11 months ago

@heshfekry @pawelkmpt When I saw that the design that was under task description was missing from Figma I asked Janeli about it. She said that @heshfekry picked after our meeting this new design. Is this correct information?

Screenshot 2023-09-06 at 15 45 46

Yes this is the same one, maybe it was moved. Basically the same with a slightly larger indent on left hand side.

freudFlintstone commented 11 months ago

@heshfekry I think we need to skip indents on mobile as full card is not displayed

Made that change for smaller screens, but I have a question: If cards are only ever rendered in lower level, does indenting actually contribute, or at least contributes enough that it's worth losing that space on larger mobile devices and tablets?

heshfekry commented 11 months ago

We need to ditch indent on mobile.