conversionxl / aybolit

Lightweight web components library built with LitElement.
https://conversionxl.github.io/aybolit/
MIT License
7 stars 8 forks source link

Upgrade Vaadin #320

Open anoblet opened 11 months ago

github-actions[bot] commented 11 months ago

size-limit report 📦

Path Size
packages/cxl-ui/pkg/dist-web/cxl-ui.js 61.53 KB (-0.1% 🔽)
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js 11.87 KB (0%)
packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js 27.11 KB (-0.01% 🔽)
packages/cxl-ui/pkg/dist-web/vendor.js 135.75 KB (+0.13% 🔺)
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js, packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js, packages/cxl-ui/pkg/dist-web/cxl-ui.js, packages/cxl-ui/pkg/dist-web/manifest.js, packages/cxl-ui/pkg/dist-web/unresolved.js, packages/cxl-ui/pkg/dist-web/vendor.js 237.41 KB (+0.05% 🔺)
lkraav commented 11 months ago

Hmm, I was thinking maybe v23 latest point release is safer, but I think we can also evaluate now whether everything still works in v24?

I remember I had some breaking changes concerns, but can't recall exactly what they were :thinking: we need to investigate v24 changelog.

anoblet commented 11 months ago

Taking smaller steps would probably be better. I'm curious, running yarn upgrade-interactive --scope '@vaadin' only updates package-lock.json and not package.json. Is this something we're comfortable with? It feels a bit unnatural to search and replace package versions for no effect.

lkraav commented 11 months ago

I'm curious, running yarn upgrade-interactive --scope '@vaadin' only updates package-lock.json and not package.json. Is this something we're comfortable with? It feels a bit unnatural to search and replace package versions for no effect.

This is referring to minor version upgrade? If constraints listed in package.json remains valid, I don't see a problem. What yarn version are you working with? This behavior may have changed over time?

anoblet commented 11 months ago

This is referring to a minor upgrade. I'm using the latest version of yarn (1.22.19), and this looks to be expected behavior: https://dev.to/wgao19/why-running-yarn-upgrade-does-not-update-my-package-json-3mon

It's a bit confusing, though I don't see a need to update constraints.