conversionxl / aybolit

Lightweight web components library built with LitElement.
https://conversionxl.github.io/aybolit/
MIT License
7 stars 8 forks source link

fix(cxl-ui): remove bad usage of storybook stories in component class #324

Closed freudFlintstone closed 1 year ago

freudFlintstone commented 1 year ago

This was not part of the sprint, but an issue identified while working on a different task.

The component cxl-dashboard-header was importing cxl-dashboard-notification storybook code and example data to use inside the elements template, seemingly instead of importing and using the actual element. I'm not sure what was the idea behind it, but it's 100% incorrect usage of both custom elements and stories, so I decided to preemptively correct it. The updated code was tested in storybook and local wp starter environment.

github-actions[bot] commented 1 year ago

size-limit report 📦

Path Size
packages/cxl-ui/pkg/dist-web/cxl-ui.js 61.5 KB (-1.06% 🔽)
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js 11.87 KB (0%)
packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js 27.07 KB (0%)
packages/cxl-ui/pkg/dist-web/vendor.js 135.58 KB (0%)
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js, packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js, packages/cxl-ui/pkg/dist-web/cxl-ui.js, packages/cxl-ui/pkg/dist-web/manifest.js, packages/cxl-ui/pkg/dist-web/unresolved.js, packages/cxl-ui/pkg/dist-web/vendor.js 237.17 KB (-0.28% 🔽)
freudFlintstone commented 1 year ago

@pawelkmpt This is important, we should not deploy without the patch