conversionxl / aybolit

Lightweight web components library built with LitElement.
https://conversionxl.github.io/aybolit/
MIT License
7 stars 8 forks source link

fix(cxl-ui): close dashboard container gap to footer #327

Closed freudFlintstone closed 1 year ago

freudFlintstone commented 1 year ago

https://app.clickup.com/t/86ay8ay1h

github-actions[bot] commented 1 year ago

size-limit report 📦

Path Size
packages/cxl-ui/pkg/dist-web/cxl-ui.js 61.64 KB (+0.09% 🔺)
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js 11.87 KB (0%)
packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js 27.11 KB (0%)
packages/cxl-ui/pkg/dist-web/vendor.js 135.58 KB (0%)
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js, packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js, packages/cxl-ui/pkg/dist-web/cxl-ui.js, packages/cxl-ui/pkg/dist-web/manifest.js, packages/cxl-ui/pkg/dist-web/unresolved.js, packages/cxl-ui/pkg/dist-web/vendor.js 237.35 KB (+0.03% 🔺)
freudFlintstone commented 1 year ago

I see horizontal scrollbar on WPS with this branch . Could you check?

I pushed a likely fix, but:

I can 't reproduce it in storybook, and my dashboard-beta page still looks like the screenshot below. Using aybolit branch raphael/fix/dashboard/container-height, I ran yarn dist and, in cxl-wpstarter/packages/institute-theme, yarn style then yarn prod. I'm using branch feat/dashoboard-2-0. What am I missing?

Screenshot from 2023-09-12 19-02-49

pawelkmpt commented 1 year ago

I can 't reproduce it in storybook, and my dashboard-beta page still looks like the screenshot below. Using aybolit branch raphael/fix/dashboard/container-height, I ran yarn dist and, in cxl-wpstarter/packages/institute-theme, yarn style then yarn prod. I'm using branch feat/dashoboard-2-0. What am I missing?

https://cxlworld.slack.com/archives/C01HXUNGEPM/p1694506459618209?thread_ts=1694498160.121789&cid=C01HXUNGEPM