conversionxl / aybolit

Lightweight web components library built with LitElement.
https://conversionxl.github.io/aybolit/
MIT License
7 stars 8 forks source link

fix(cxl-ui): fix course card layout issues #337

Closed freudFlintstone closed 1 year ago

freudFlintstone commented 1 year ago

https://app.clickup.com/t/86ayagj21

github-actions[bot] commented 1 year ago

size-limit report 📦

Path Size
packages/cxl-ui/pkg/dist-web/cxl-ui.js 63.29 KB (+0.1% 🔺)
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js 11.87 KB (0%)
packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js 27.55 KB (0%)
packages/cxl-ui/pkg/dist-web/vendor.js 135.58 KB (0%)
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js, packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js, packages/cxl-ui/pkg/dist-web/cxl-ui.js, packages/cxl-ui/pkg/dist-web/manifest.js, packages/cxl-ui/pkg/dist-web/unresolved.js, packages/cxl-ui/pkg/dist-web/vendor.js 239.43 KB (+0.03% 🔺)
freudFlintstone commented 1 year ago

This view is broken. Please check if just Storybook or bigger issue: https://deploy-preview-337--conversionxl-aybolit.netlify.app/?path=/story/cxl-ui-cxl-course-card--courses-dashboard-different-heights

It was , in fact, only about the storybook layout. But it does also mean we have to consider that when implementing the new institute home page grid. This is after the fix: image