Closed freudFlintstone closed 1 year ago
Starting Draft PR so we are able to start testing each component early. The header is available
Path | Size |
---|---|
packages/cxl-ui/pkg/dist-web/cxl-ui.js | 66.81 KB (+2.56% 🔺) |
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js | 11.87 KB (0%) |
packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js | 27.77 KB (+0.03% 🔺) |
packages/cxl-ui/pkg/dist-web/vendor.js | 135.58 KB (0%) |
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js, packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js, packages/cxl-ui/pkg/dist-web/cxl-ui.js, packages/cxl-ui/pkg/dist-web/manifest.js, packages/cxl-ui/pkg/dist-web/unresolved.js, packages/cxl-ui/pkg/dist-web/vendor.js | 243.18 KB (+0.7% 🔺) |
Solid thank you.
Task linked: CU-86ayd0hrw Team dashboard
Resolve conflicts
@pawelkmpt It's not broken. You probably forgot to run yarn build-styling after changing branches.
@pawelkmpt It's not broken. You probably forgot to run yarn build-styling after changing branches.
I visually test mostly on the Storybook attached to the PR. I just tested in two ways: dev tools and Storybook mobile control and both are fixed for tablet but still broken for small mobile (missing padding). We do style things starting at 320 px width. You seem to keep forgetting it.
@pawelkmpt I try to use a mobile first approach on style, as it's simpler and our standard media queries (in the _mq.scss file) all use min-width thresholds. That way I don't forget about it, but I'll check more sizes next time.
The problem here was that the cxl-stats
component is not properly responsive, and it pushes the boundaries of the container on the smallest screen.
Fixed by forcing different box-sizing on inner container div.
@freudFlintstone please rebase on top of master
https://app.clickup.com/t/86ayd0hrw