search

conversionxl / aybolit

Lightweight web components library built with LitElement.
https://conversionxl.github.io/aybolit/
MIT License
7 stars 8 forks source link

refactor(cxl-ui): cxl-section - remove top margin #369

Closed freudFlintstone closed 11 months ago

freudFlintstone commented 12 months ago

From discussion: https://cxlworld.slack.com/archives/C01HXUNGEPM/p1701945675624519

github-actions[bot] commented 12 months ago

size-limit report 📦

Path Size
packages/cxl-ui/pkg/dist-web/cxl-ui.js 68.76 KB (-0.07% 🔽)
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js 11.89 KB (0%)
packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js 28.13 KB (0%)
packages/cxl-ui/pkg/dist-web/vendor.js 136.06 KB (0%)
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js, packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js, packages/cxl-ui/pkg/dist-web/cxl-ui.js, packages/cxl-ui/pkg/dist-web/manifest.js, packages/cxl-ui/pkg/dist-web/unresolved.js, packages/cxl-ui/pkg/dist-web/vendor.js 246.01 KB (-0.02% 🔽)
lkraav commented 11 months ago

I would've thought

https://github.com/conversionxl/aybolit/blob/0e1091cd6f67b5bd9ab14547f8982ebb445fe8d3/packages/cxl-ui/scss/cxl-section.scss#L64 just this needs to go away?

I see a :+1: emoji but no updates to PR?

freudFlintstone commented 11 months ago

I would've thought https://github.com/conversionxl/aybolit/blob/0e1091cd6f67b5bd9ab14547f8982ebb445fe8d3/packages/cxl-ui/scss/cxl-section.scss#L64

just this needs to go away?

I see a 👍 emoji but no updates to PR?

@lkraav, done. Got distracted and forgot.