conversionxl / aybolit

Lightweight web components library built with LitElement.
https://conversionxl.github.io/aybolit/
MIT License
7 stars 8 forks source link

feat(cxl-lumo-styles): update typography #381

Closed anoblet closed 5 months ago

anoblet commented 6 months ago

Clickup: https://app.clickup.com/t/86ayy0gy1

github-actions[bot] commented 6 months ago

size-limit report 📦

Path Size
packages/cxl-ui/pkg/dist-web/cxl-ui.js 71.14 KB (+2.07% 🔺)
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js 11.89 KB (0%)
packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js 28.84 KB (+0.02% 🔺)
packages/cxl-ui/pkg/dist-web/vendor.js 140.5 KB (0%)
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js, packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js, packages/cxl-ui/pkg/dist-web/cxl-ui.js, packages/cxl-ui/pkg/dist-web/manifest.js, packages/cxl-ui/pkg/dist-web/unresolved.js, packages/cxl-ui/pkg/dist-web/vendor.js 253.52 KB (+0.58% 🔺)
heshfekry commented 6 months ago

H1 - Raleway font, weight 900, size 65px, line height 65px H2 - Raleway font, weight 900, H3 - Raleway font, weight 700, H4 - Raleway font, weight 500,

Frame 5509 (2)

image

Ill QA again after these changes @anoblet as its hard to judge the rest without some of these changes.

heshfekry commented 6 months ago

Task linked: CU-86ayy0gy1 Change fonts

pawelkmpt commented 6 months ago
Screenshot 2024-01-04 at 21 34 18

cxl-course-card needs header adjustment for .name too (screenshot from WPS)

pawelkmpt commented 6 months ago

Storybook looks different than compiled aybolit applied on WPS. Mostly due the primary font family. On WPS all text uses Lato. Storybook still has Roboto and Libre on some elements eg. menu.

@heshfekry do we want everything Lato?

Screenshot 2024-01-08 at 11 00 33

Dashboard cards need tweaks for headings. Titles have too big margins.

localhost_8080_dashboard_

heshfekry commented 6 months ago

@pawelkmpt

Yes we do want everything lato. We shouldn't see roboto or liber anywhere. Keep things simple as our typography system, is sub optimal.

Agree that the cards need a tweak.

pawelkmpt commented 6 months ago

I fixed margins cc @anoblet

Screenshot 2024-01-08 at 13 11 29 Screenshot 2024-01-08 at 13 11 43

and found one more thing, certificates new vs old style. Screenshot 2024-01-08 at 13 05 59

heshfekry commented 6 months ago

This title can be changed to Raleway font-weight 900 for sure

image

Rest can stay the same

pawelkmpt commented 6 months ago

I cleaned up commits and squashed them into just 3