conversionxl / aybolit

Lightweight web components library built with LitElement.
https://conversionxl.github.io/aybolit/
MIT License
7 stars 8 forks source link

Certificate header: credential fit #384

Closed pawelkmpt closed 5 months ago

pawelkmpt commented 5 months ago

Result after changes

Screenshot 2024-01-11 at 11 44 03 Screenshot 2024-01-11 at 11 44 18 Screenshot 2024-01-11 at 11 44 51 Screenshot 2024-01-11 at 11 45 11 Screenshot 2024-01-11 at 11 46 22 Screenshot 2024-01-11 at 11 46 35

github-actions[bot] commented 5 months ago

size-limit report 📦

Path Size
packages/cxl-ui/pkg/dist-web/cxl-ui.js 71.7 KB (+0.76% 🔺)
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js 11.89 KB (0%)
packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js 28.84 KB (0%)
packages/cxl-ui/pkg/dist-web/vendor.js 140.5 KB (0%)
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js, packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js, packages/cxl-ui/pkg/dist-web/cxl-ui.js, packages/cxl-ui/pkg/dist-web/manifest.js, packages/cxl-ui/pkg/dist-web/unresolved.js, packages/cxl-ui/pkg/dist-web/vendor.js 254.08 KB (+0.22% 🔺)
pawelkmpt commented 5 months ago

Task linked: CU-86ayg4prn Course complete page

heshfekry commented 5 months ago

@pawelkmpt

Certificate looks fine.

Unrelated to this but since its here too.

pawelkmpt commented 5 months ago

Certificate looks fine.

Unrelated to this but since its here too.

  • Course title > H1
  • Course completed > h2
  • I noticed the same on MD 2,0 pages too. Title is a large lato instead of an H1.

@heshfekry better?

Screenshot 2024-01-11 at 14 28 31

lkraav commented 5 months ago

Sports psychology talks about avoiding negatives, like Don't stop, which puts the word Stop in athlete mind.

Better: «Keep going!»