conversionxl / aybolit

Lightweight web components library built with LitElement.
https://conversionxl.github.io/aybolit/
MIT License
7 stars 8 forks source link

refactor(cxl-lumo-styles): typography Raleway -> Montserrat #386

Closed pawelkmpt closed 10 months ago

github-actions[bot] commented 10 months ago

size-limit report 📦

Path Size
packages/cxl-ui/pkg/dist-web/cxl-ui.js 71.73 KB (+0.06% 🔺)
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js 11.89 KB (0%)
packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js 28.84 KB (+0.03% 🔺)
packages/cxl-ui/pkg/dist-web/vendor.js 140.5 KB (0%)
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js, packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js, packages/cxl-ui/pkg/dist-web/cxl-ui.js, packages/cxl-ui/pkg/dist-web/manifest.js, packages/cxl-ui/pkg/dist-web/unresolved.js, packages/cxl-ui/pkg/dist-web/vendor.js 254.12 KB (+0.02% 🔺)
pawelkmpt commented 10 months ago

H3

I suggest to either:

Please look at the screenshots attached. One of the cards has title with 700 instead of 900.

Screenshot 2024-01-12 at 11 31 16 Screenshot 2024-01-12 at 11 31 37

heshfekry commented 10 months ago

Course Cards should have same weight. Lets go with 700 as its saner to maintain.

If its trivial I would even switch this to Lato.

pawelkmpt commented 10 months ago

Course Cards should have same weight. Lets go with 700 as its saner to maintain.

I was not clear enough. I made one of them 700 to show the difference in look. By default all are 900.

If its trivial I would even switch this to Lato.

OK, I will adjust.

pawelkmpt commented 10 months ago

@heshfekry done

Screenshot 2024-01-12 at 12 36 05 Screenshot 2024-01-12 at 12 36 10

what about featured courses? which version do you like more? Screenshot 2024-01-12 at 12 35 46

heshfekry commented 10 months ago

featured courses - Use montserrat.

heshfekry commented 10 months ago

For the rest seems fine @pawelkmpt