search

conversionxl / aybolit

Lightweight web components library built with LitElement.
https://conversionxl.github.io/aybolit/
MIT License
7 stars 8 forks source link

feat(cxl-ui): [cxl-certificate-header] update completed page #399

Closed anoblet closed 7 months ago

anoblet commented 7 months ago

https://app.clickup.com/t/86azbhf5m

Desktop:

localhost_course_a-b-testing-foundations__completed

Mobile:

localhost_course_a-b-testing-foundations__completed(iPhone SE)

github-actions[bot] commented 7 months ago

size-limit report 📦

Path Size
packages/cxl-ui/pkg/dist-web/cxl-ui.js 72.35 KB (+0.04% 🔺)
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js 11.89 KB (0%)
packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js 29.04 KB (0%)
packages/cxl-ui/pkg/dist-web/vendor.js 140.5 KB (0%)
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js, packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js, packages/cxl-ui/pkg/dist-web/cxl-ui.js, packages/cxl-ui/pkg/dist-web/manifest.js, packages/cxl-ui/pkg/dist-web/unresolved.js, packages/cxl-ui/pkg/dist-web/vendor.js 254.94 KB (+0.02% 🔺)
pawelkmpt commented 7 months ago

@anoblet why solution with MediaQueryController controller is better than simply hiding credential with CSS?

Especially in situation when _wideMediaQuery = '(min-width: 528px)'; is different from CSS MQ values (closest: $small: 568px).

@anoblet ping

anoblet commented 7 months ago

@pawelkmpt True. I was unsure which was the best strategy. Updated :)