search

conversionxl / aybolit

Lightweight web components library built with LitElement.
https://conversionxl.github.io/aybolit/
MIT License
7 stars 8 forks source link

refactor(cxl-ui): cxl-star-rating remove _updateReadonlyAndValue #410

Closed paulkirspuu closed 2 months ago

paulkirspuu commented 2 months ago

This is necessary to prevent the component from saving default value on each usage case. We prefer it being zero at all times.

https://app.clickup.com/t/86azy6kx9?comment=90140034479841&threadedComment=90140035014093

github-actions[bot] commented 2 months ago

size-limit report 📦

Path Size
packages/cxl-ui/pkg/dist-web/cxl-ui.js 75.87 KB (-0.02% 🔽)
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js 11.89 KB (0%)
packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js 28.85 KB (-0.06% 🔽)
packages/cxl-ui/pkg/dist-web/vendor.js 140.5 KB (0%)
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js, packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js, packages/cxl-ui/pkg/dist-web/cxl-ui.js, packages/cxl-ui/pkg/dist-web/manifest.js, packages/cxl-ui/pkg/dist-web/unresolved.js, packages/cxl-ui/pkg/dist-web/vendor.js 258.27 KB (-0.02% 🔽)
lkraav commented 2 months ago

This is necessary to prevent the component from saving default value on each usage case.

What did we save the value for - so user would know they've already rated something?

pawelkmpt commented 2 months ago

What did we save the value for - so user would know they've already rated something?

Component was developed for playbooks and I don't remember if ever used. There was an alternative thumbs up/down component too.