search

conversionxl / aybolit

Lightweight web components library built with LitElement.
https://conversionxl.github.io/aybolit/
MIT License
7 stars 8 forks source link

feat(cxl-ui): cxl-featured-image add component #413

Closed anoblet closed 5 months ago

anoblet commented 6 months ago

https://app.clickup.com/t/86b0647n0

image

github-actions[bot] commented 6 months ago

size-limit report 📦

Path Size
packages/cxl-ui/pkg/dist-web/cxl-ui.js 44.2 KB (+1.15% 🔺)
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js 11.89 KB (0%)
packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js 28.99 KB (0%)
packages/cxl-ui/pkg/dist-web/vendor.js 138.23 KB (0%)
packages/cxl-ui/pkg/dist-web/cxl-ui-institute.js, packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js, packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js, packages/cxl-ui/pkg/dist-web/cxl-ui.js, packages/cxl-ui/pkg/dist-web/manifest.js, packages/cxl-ui/pkg/dist-web/unresolved.js, packages/cxl-ui/pkg/dist-web/vendor.js 275.8 KB (+0.19% 🔺)
pawelkmpt commented 6 months ago

One more thing, it should be visible on mobile only. Now question is whether it's better to encapsulate visibility inside the component or control it with external CSS. I don't know the answer yet

anoblet commented 6 months ago

One more thing, it should be visible on mobile only. Now question is whether it's better to encapsulate visibility inside the component or control it with external CSS. I don't know the answer yet

The correct way would be to do it from the outside, though it wouldn't be a big deal taking a shortcut here.

pawelkmpt commented 5 months ago

One more thing needed

export { CXLFeaturedImage } from './components/cxl-featured-image';

anoblet commented 5 months ago