conversionxl / aybolit

Lightweight web components library built with LitElement.
https://conversionxl.github.io/aybolit/
MIT License
7 stars 8 forks source link

Styles #434

Closed anoblet closed 1 month ago

anoblet commented 1 month ago

https://app.clickup.com/t/86b1dy579

github-actions[bot] commented 1 month ago

size-limit report 📦

Path Size
packages/cxl-ui/pkg/dist-web/cxl-ui.js 44.75 KB (-0.01% 🔽)
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js 11.89 KB (0%)
packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js 29.23 KB (0%)
packages/cxl-ui/pkg/dist-web/vendor.js 138.23 KB (0%)
packages/cxl-ui/pkg/dist-web/cxl-ui-institute.js, packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js, packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js, packages/cxl-ui/pkg/dist-web/cxl-ui.js, packages/cxl-ui/pkg/dist-web/manifest.js, packages/cxl-ui/pkg/dist-web/unresolved.js, packages/cxl-ui/pkg/dist-web/vendor.js 277.57 KB (-0.01% 🔽)
pawelkmpt commented 1 month ago

Please also commit "Increase font size" styles which are currently in institute customizer

@anoblet follow up

anoblet commented 1 month ago

Will get it done by EOD.

anoblet commented 1 month ago

We have these styles in customizer, which conflict with what's in this PR:

details {
  margin: var(--lumo-space-m) 0;
}

details summary {
  font-weight: 900;
  margin-bottom: var(--lumo-space-s);
}

I believe that we should remove these from customizer and go with what's in this PR.

pawelkmpt commented 1 month ago

We have these styles in customizer, which conflict with what's in this PR:

details {
  margin: var(--lumo-space-m) 0;
}

details summary {
  font-weight: 900;
  margin-bottom: var(--lumo-space-s);
}

I believe that we should remove these from customizer and go with what's in this PR.

Where do you see the conflict? Native details are used for FAQ, e.g. https://cxl.com/institute/programs/conversion-optimization/ and what you pushed here is for vaadin-details https://cxl.com/institute/lesson/where-and-what-to-test-to-maximize-roi/