search

convertersystems / opc-ua-client

Visualize and control your enterprise using OPC Unified Architecture (OPC UA) and Visual Studio.
MIT License
405 stars 119 forks source link

Updated Microsoft.IO.RecyclableMemoryStream to version 3.0.0. #266

Open dxdjgl opened 11 months ago

trivalik commented 10 months ago

This is indeed a good idea, since version 3 has a breaking change in RecyclableMemoryStreamManager.GetStream(string) (return value has changed). alternative would be to set Version="[2.2.1,3.0.0)".

dxdjgl commented 9 months ago

Hope it can merge and a build can be release soon.

awcullen commented 9 months ago

I have updated Microsoft.IO.RecyclableMemoryStream to version 3.0.0 and found no issues. I like the new functions in RecyclableMemoryStream. In the future, we could improve the encoder performance.

trivalik commented 9 months ago

@awcullen You would get a issue in case you have another library which require use of RecyclableMemoryStream with version 2, because of the breaking change mentioned above.

see https://github.com/microsoft/Microsoft.IO.RecyclableMemoryStream/issues/324