search

convertigo / c8osdk-angular-caf

CAF brings to Angular / Ionic 2+ the same functionalities that CTF (Convertigo Templating Framework) brings to JQuery. The goal is to add Convertigo back end support directly in to the Ionic HTML templates without having to program complex TypeScript.
http://www.convertigo.com
Apache License 2.0
2 stars 1 forks source link

Response is stored twice into the c8oResponses array #10

Closed CharlesGrimont closed 6 years ago

CharlesGrimont commented 6 years ago

The execute_route function of router, calls twice storeResponseForView.

The direct consequence of this is causing some troubles such as non refreshing page.

CharlesGrimont commented 6 years ago

So we must add a return statment to execute_route function of router in case of push of root page. This prevent us from calling twice storeResponseForView. In fact storeResponseForView is called into the constructor of the target page, so if we push or root a new page we want to avoid the call of storeResponseForView for the current at the end of execute_route function...

CharlesGrimont commented 6 years ago

Fixed into https://github.com/convertigo/c8osdk-angular-caf/commit/17d10beb0b872e3ea6625b172d734b6eac3d5eda and https://github.com/convertigo/c8osdk-angular-caf/commit/f2fa6518f8a3175452c1e6ad3e810dae87ac4347