Closed mayork closed 7 years ago
Btw, since I am trying to debug some idiosyncrasies of CFP_Fuselage atm, I think we should sit and wait on this pull request a little bit. But feel free to keep developing in the meanwhile; it is nothing that will affect the engine integration.
@1ozturkbe the engine isn't involved in the fuselage model at all, right?
Nope. There is a single constraint that makes sure that the vertical tail is at least 4*engine radius. Let me know if there is any other way I can help. Thankfully the engine is not highly coupled to Aircraft and AircraftP atm, but the integration might still give headaches.
If you have a lot of trouble getting it to work, I would recommend updating CFP until the latest commit 50f1b47. It is a lot more... stable than the previous commits :P
I found a bug. In StateLinking model, you have two for loops, one for linking climb, and one for linking cruise segments. But they are both iterating over Nclimb. That should help?
ah good catch. didn't make a difference here since the two values were equal but certainly was a bug.
I think i'll try and update to the new CFP...although it might be best if we do that together tomorrow by just doing a merge deconflict. what time are you free?
I am free from 10-3. Let me know when you can make it. Also, just to whet your appetite:
Not complete by any means, but a good start.
that looks awesome! and okay i'll shoot you a text around 10 and come over
@1ozturkbe what i'm going to do is move all the engine integration stuff into the newest commit, but then we should both start working off of that one
Btw, should we close this issue at this point? It seems moot.
yep this is done
branch where engine model integration is being completed