convexengineering / SPaircraft

Models for commercial aircraft design
http://spaircraft.readthedocs.org
25 stars 17 forks source link

Engine integration #11

Closed mayork closed 7 years ago

mayork commented 7 years ago

branch where engine model integration is being completed

1ozturkbe commented 7 years ago

Btw, since I am trying to debug some idiosyncrasies of CFP_Fuselage atm, I think we should sit and wait on this pull request a little bit. But feel free to keep developing in the meanwhile; it is nothing that will affect the engine integration.

mayork commented 7 years ago

@1ozturkbe the engine isn't involved in the fuselage model at all, right?

1ozturkbe commented 7 years ago

Nope. There is a single constraint that makes sure that the vertical tail is at least 4*engine radius. Let me know if there is any other way I can help. Thankfully the engine is not highly coupled to Aircraft and AircraftP atm, but the integration might still give headaches.

1ozturkbe commented 7 years ago

If you have a lot of trouble getting it to work, I would recommend updating CFP until the latest commit 50f1b47. It is a lot more... stable than the previous commits :P

1ozturkbe commented 7 years ago

I found a bug. In StateLinking model, you have two for loops, one for linking climb, and one for linking cruise segments. But they are both iterating over Nclimb. That should help?

mayork commented 7 years ago

ah good catch. didn't make a difference here since the two values were equal but certainly was a bug.

I think i'll try and update to the new CFP...although it might be best if we do that together tomorrow by just doing a merge deconflict. what time are you free?

1ozturkbe commented 7 years ago

I am free from 10-3. Let me know when you can make it. Also, just to whet your appetite:

d8

Not complete by any means, but a good start.

mayork commented 7 years ago

that looks awesome! and okay i'll shoot you a text around 10 and come over

mayork commented 7 years ago

@1ozturkbe what i'm going to do is move all the engine integration stuff into the newest commit, but then we should both start working off of that one

1ozturkbe commented 7 years ago

Btw, should we close this issue at this point? It seems moot.

mayork commented 7 years ago

yep this is done