search

convexengineering / SPaircraft

Models for commercial aircraft design
http://spaircraft.readthedocs.org
25 stars 17 forks source link

prepare for model verification #116

Closed bqpd closed 6 years ago

bqpd commented 6 years ago

for convexengineering/gpkit#1238

bqpd commented 6 years ago

@mayork or @1ozturkbe, could you review this?

mayork commented 6 years ago

@bqpd out of curiosity what is "verification"

bqpd commented 6 years ago

heh, every time an instance of a named model is created we will check to make sure that it's appropriately bounded. With this it should be possible to guarantee dual feasibility and modularity before solving.

mayork commented 6 years ago

@bqpd oh awesome! are we skipping that step for everything in this repo?

mayork commented 6 years ago

just not sure what the skip verification means

bqpd commented 6 years ago

yup yup. It should be doable to integrate signomials / sigeqs but I haven't tried to write that algorithm yet :p

bqpd commented 6 years ago

I'd love to piece-by-piece integrate these models into that framework, though! I think it's really going to be a good change to the way gpkit model development works.

mayork commented 6 years ago

@bqpd yeah this sounds like a great feature! I'm reviewing paper proofs right now but when I'm done with that (hopefully tomorrow night) I'll take a look at these