Collapsing fan diameter (!?)

convexengineering / SPaircraft

Models for commercial aircraft design

http://spaircraft.readthedocs.org

25 stars 17 forks source link

Closed 1ozturkbe closed 6 years ago

1ozturkbe commented 6 years ago

Although there were no changes to any of the models, the latest push on master has a tiny fan diameter (10^-7m). Will look into shortly.

mayork commented 6 years ago

do you mean that PR you merged? If so, I think we need to revert until the paper is through reviews unless the cause of the bug is obvious

1ozturkbe commented 6 years ago

No it's fine now... I pulled turbofan and it fixed it. Don't know what happened at all...

mayork commented 6 years ago

Sounds great

bqpd commented 6 years ago

(if you're worried about this happening again, please add a test so that I'll notice when it happens!)