search

convexengineering / SPaircraft

Models for commercial aircraft design
http://spaircraft.readthedocs.org
25 stars 17 forks source link

TASOPT flight profile #13

Closed mayork closed 7 years ago

mayork commented 7 years ago

upgrading the aircraft model to the TASOPT flight profile for validation purposes

1ozturkbe commented 7 years ago

Cool! Can you outline the main differences between this flight profile and the simple one? Because it seems that this also has 2 climb and cruise segments. Furthermore, numeng is still set to 1 from when we were debugging the fuel consumption errors. Perhaps that should be changed. Also, just curious, why are you constraining Mach number in the cruise segments?

mayork commented 7 years ago

it's not done yet, hence some of the things you mentioned.

This will include reserve fuel descent and the tasopt cruise climb with constant mach and CL

we need this for validation

1ozturkbe commented 7 years ago

Ok cool. Will merge!

1ozturkbe commented 7 years ago

Feel free to keep working on the branch or to delete it Martin .

mayork commented 7 years ago

i'm going ot keep working on it....wasn't supposed to be merged yet since it's not done

bqpd commented 7 years ago

Also looks like it broke tests above, so I might have to remove you guys from unit testing on GPkit PRs...

mayork commented 7 years ago

do all the PRs get tested or just master? this branch wasn't supposed to be merged so if only master is tested Berk should just undo the merge

1ozturkbe commented 7 years ago

I don't understand why this is being tested... The only files within TESTS are CFP_Fuselage_Performance.py and CFP_Fuselage_Performance_int_9e5793.py, which shouldn't raise any issues. Nvm, I will revert.
Also, in the future, can we hold up on making pull requests unless you would like something merged?

bqpd commented 7 years ago

Or you could do what @whoburg and I do, and flag PRs that are ready to be merged with @reviewer, ready for review

bqpd commented 7 years ago

All PRs are tested! :D I don't know why this one is failling, but it does look like it might be a jenkins issue...paging @galbramc while I dig in

1ozturkbe commented 7 years ago

K, whatever floats your boat! Reverting.