convexengineering / SPaircraft

Models for commercial aircraft design
http://spaircraft.readthedocs.org
25 stars 17 forks source link

SPaircraft convergence issue #138

Closed naschwa closed 4 years ago

naschwa commented 4 years ago

The gas constant "R" and graviational acceleration "g" defined in the turbofan repository are both reported to have "no lower bound," thus causing SPaircraft.py to diverge. Error message is attached. error.txt

1ozturkbe commented 4 years ago

I recognize the error. This is something that happens mid-GP solve, which is curious. Pretty certain the cause is that the model no longer closes and it is infeasible. I am just pushing a fix at #139 so we can see if that resolves the issue.

1ozturkbe commented 4 years ago

It seems that there is more interest in SPaircraft recently, so I made updates to both turbofan and SPaircraft. Master version of SPaircraft with these updates should close, to a 'satisfactory' optimum. Note that we size things differently relative to TASOPT, so there will be some big diffs. Let me know if this doesn't work for you!

1ozturkbe commented 4 years ago

Tests are passing on all machines as well as my machine, so closing. Can figure this on a particular machine basis.