convexengineering / SPaircraft

Models for commercial aircraft design
http://spaircraft.readthedocs.org
25 stars 17 forks source link

Merging genVSP #38

Closed 1ozturkbe closed 7 years ago

1ozturkbe commented 7 years ago

@mayork I want to merge genVSP into master, but it seems like there are some inconsistent constraints within multimission.

1ozturkbe commented 7 years ago

Firstly:

        if not multimission:
               constraints.extend([
                    aircraft['n_{pax}'] == 180.,
                    ReqRng == 3000.*units('nmi'),
                    ])

This constraint is going to be badly behaved if we sweep n_{pax}. Why not just have a substitution instead?

mayork commented 7 years ago

i'm not sure how to sub a vector into a vector variable hence we can't use subs and multimission together

1ozturkbe commented 7 years ago

That's really poopy and inconvenient. Perhaps I will hold off for a little bit... Does multimission now work with the near-optimal fix? Perhaps then it is better to integrate the updated cruise climb constraints.

mayork commented 7 years ago

Nah it keeps crashing my python, not sure why. Try integrating the new cruise climb first

On Mar 20, 2017, at 2:15 PM, Berk Ozturk notifications@github.com wrote:

That's really poopy and inconvenient. Perhaps I will hold off for a little bit... Does multimission now work with the near-optimal fix? Perhaps then it is better to integrate the updated cruise climb constraints.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/hoburg/d8/pull/38#issuecomment-287850311, or mute the thread https://github.com/notifications/unsubscribe-auth/AGe0f2nIvOeKN654pl2WbJobajDrB-1Dks5rnsJEgaJpZM4Miz-t.

1ozturkbe commented 7 years ago

Here's what I'm gonna do. I'm going to add cruiseclimb2 to genVSP. I'm going to confirm it works as expected. Then I'm going to add it to master by hand as well, because I don't want to deal with a gajillion merge conflicts. And it should work like a charm. Afterwards, we can just delete the cruiseclimb2 branch.

1ozturkbe commented 7 years ago

Also, hell yeah, Ned's new code totally works with near optimals!

1ozturkbe commented 7 years ago

@mayork cruise climb works like butter! All altitude constraints are tight, and although we get a few NEAR_OPTIMALs, it successfully hops over them. You could probably integrate the constraints yourself to get multimission working (I don't want to pull master right now because group meeting...) Look at commits 47d95ad1 and dd9419d9 under genVSP. Should be really straightforward!

1ozturkbe commented 7 years ago

I'm going to close this and actually merge the final genVSP, which has the appropriate cruise climb constraints.