search

convexengineering / SPaircraft

Models for commercial aircraft design
http://spaircraft.readthedocs.org
25 stars 17 forks source link

Removing engine specific variables from Aircraft and AircraftP in D8. #48

Closed 1ozturkbe closed 7 years ago

1ozturkbe commented 7 years ago

Hey @mayork, would it be possible to do this? I feel it is cluttering up D8 and also inconsistent with the hierarchy of the model.

mayork commented 7 years ago

give an example

1ozturkbe commented 7 years ago

Snace, CDnace etc. these should be inherited from submodels, not existing within Aircraft.

mayork commented 7 years ago

nacelle is not considered part of the engine so i'd rather leave it with the airframe

1ozturkbe commented 7 years ago

Arrgghh it sticks out like a sore thumb to me... in the short term I will put up with my discomfort, since it is low priority.

1ozturkbe commented 7 years ago

I'm going to close this issue, since I am better convinced now that the nacelle stuff belongs in the Aircraft class.