search

convexengineering / SPaircraft

Models for commercial aircraft design
http://spaircraft.readthedocs.org
25 stars 17 forks source link

Call d8 subs from separate files. #49

Closed 1ozturkbe closed 7 years ago

1ozturkbe commented 7 years ago

This is an improvement to reduce clutter and try to avoid inconsistent substitutions. We should start pulling subs from external python files, and be able to see every single substitution for each aircraft (D82, b737800, 737ER, 777 etc.), without doing the subs.update business from D8.py.

mayork commented 7 years ago

yeah this is a good call, it'd solve the testing problem as well

1ozturkbe commented 7 years ago

Btw Martin, thanks for the awesome work you have done on making this happen! I'm going to leave this open until we iron out all of the issues w.r.t the subs.

mayork commented 7 years ago

Seems like all the subs are working at the same level they were before (I just tested the other files). I'm fine to close whenever you are.

mayork commented 7 years ago

this is done, files are validating. closing now.