convexengineering / SPaircraft

Models for commercial aircraft design
http://spaircraft.readthedocs.org
25 stars 17 forks source link

Fuselage height untight #57

Closed 1ozturkbe closed 7 years ago

1ozturkbe commented 7 years ago

Tried basic fixes and failed to prevent. Not a huge priority (doesn't heavily affect design outcomes), but still concerning. Will post updates here.

1ozturkbe commented 7 years ago

Still noticing this issue in the models... Will need to resolve soon.

1ozturkbe commented 7 years ago

@mayork this is a significant issue... we still have cabin volume increasing beyond reason, because our drag model still doesn't have any penalty for increased volume. So wonky... I got in touch with Haofeng about doing MTflow stuff (he has already gotten it working on an Athena cluster), and I'm going to help him automate sweeps to do fits on. Should resolve this issue. Until this is done, I would not trust any of the results :/

1ozturkbe commented 7 years ago

Also, noticed that subs were missing in D8_engwing for delta R{fuse}. Should fix D8-type aircraft results. The tightness issue will keep showing up in conventional aircraft however.

mayork commented 7 years ago

i don't see what we set delta R_{fuse} to though.

1ozturkbe commented 7 years ago

I set it to default 0.43m for D8-class aircraft. 0 for sweeps. And also, some of the subs aren't going through!? Anyways, gotta go to the IM game, but afterwards I'll keep trying.

mayork commented 7 years ago

I do not think that's legit. We need a systematic way to set it.

1ozturkbe commented 7 years ago

It was just some issues with subs... I'll pull request everything from readthedocs over, then keep working on the docs.

mayork commented 7 years ago

so how are we setting DRfuse for the D8 class?

1ozturkbe commented 7 years ago

for a general 8 SPR, just set to 0.43m default. Otherwise, not clear. For conventional A/C, its just 0. For D8's with other SPR, it might just make sense to scale with SPR.