search

convexengineering / SPaircraft

Models for commercial aircraft design
http://spaircraft.readthedocs.org
25 stars 17 forks source link

Sizing Variables to Aircraft(Model) #6

Closed 1ozturkbe closed 7 years ago

1ozturkbe commented 7 years ago

Since variables like V_{NE}, and rho_0 appear in every single component (VT, HT, Fuselage), they should definitely moved to the Aircraft hyperclass. Same with xCG, xAC, especially since the equations concerning these variables appear in Aircraft() and AircraftP() anyways.

1ozturkbe commented 7 years ago

As of cb63fa52, these haven't been fixed, as a reference.

mayork commented 7 years ago

good all i was thinking we needed to do this and hand't gotten around to it

1ozturkbe commented 7 years ago

It has been done in CFP_Fuselage_Performance_int_HT, but not in other models. I'd appreciate it @mayork if you could do this for the HT, VT and Wing models. I believe I have already made some edits in HT to help in this respect.

1ozturkbe commented 7 years ago

Any update on this @mayork? I remember you mentioning that you had been fixing the hierarchy.

1ozturkbe commented 7 years ago

This has been completed, as of c002a5e1 (in the D8 submodels). Closing.