search

convexengineering / SPaircraft

Models for commercial aircraft design
http://spaircraft.readthedocs.org
25 stars 17 forks source link

June 13 commits result in large model errors #83

Closed mayork closed 7 years ago

mayork commented 7 years ago

@1ozturkbe after I pulled and merged I'm getting fuel burn errors >>100%...I reverted to https://github.com/hoburg/d8/commit/d44a411e4976a65986c5df1ca6ac6258299c5e48 and everything works fine. I think something happened in the 13 June series of commits

mayork commented 7 years ago

reverting also resolved that issue with the 777 validation case

1ozturkbe commented 7 years ago

That is so odd... everything working perfectly for me.

1ozturkbe commented 7 years ago

Ran it again, and I'm only getting 2% error in fuel burn for D8. Are you sure about this? Mind you, I haven't merged the June 19th commits; I'm a little confused as to why some of the subs have changed.

mayork commented 7 years ago

Merge the June 19th and see what happens?

1ozturkbe commented 7 years ago

Still works? Odd. Did you update your version of gpkit? And btw, I'm running it from nomialmap.

1ozturkbe commented 7 years ago

@mayork let me know when you run it next. But I know you are on vacation, so no pressure.

1ozturkbe commented 7 years ago

@mayork bump. Would like to make sure you can run everything reliably.

mayork commented 7 years ago

looks like i can run everything reliably right now

1ozturkbe commented 7 years ago

Excellente! Closing.