convexengineering / SPaircraft

Models for commercial aircraft design
http://spaircraft.readthedocs.org
25 stars 17 forks source link

Latex outputs of turbofan need cleaning. #87

Closed 1ozturkbe closed 7 years ago

1ozturkbe commented 7 years ago

@mayork when I printed sol.table(latex = 2) for any of the SPaircraft, I realized that the variable naming was not very good, usually due to the inconsistent use of brackets {}. I am scrubbing the code once again to make sure that the latex has the absolute minimum processing needed, but I need your help for stuff in hoburg/turbofan (I don't want to mess anything up). I will post the problematic variables here, and perhaps you can clean up both turbofan and make the necessary changes in SPaircraft.

1ozturkbe commented 7 years ago

Problematic names:

1ozturkbe commented 7 years ago

I have scrubbed the variables in the rest of the models; only engine variables left.

mayork commented 7 years ago

I scrubbed everything and found additional items (no guarantees it's a 100% fix but it's close). It's all fixed by commit https://github.com/hoburg/turbofan/commit/481777b98d186dce1aefc5354a3fdd3236d06b44. Closing this issue for now.

@1ozturkbe remember to pull turbofan

mayork commented 7 years ago

@1ozturkbe one thing to note is that i didn't update any subs in this repo. I can do that to a could of the main files. Want it in a PR or straight onto master?

1ozturkbe commented 7 years ago

Ooooooh, if you could update subs too that would be great. straight onto master please.

mayork commented 7 years ago

i updated optimal 737 and D8 as well as the 3 analysis cases. that's all I had time to do right now but I think those are the most important files.

1ozturkbe commented 7 years ago

K. I will not be able to merge the HT update until the rest are done. Are you doing this manually?

mayork commented 7 years ago

Yeah but it takes like 5 seconds per file...very little in the subs was changed

1ozturkbe commented 7 years ago

K good to know. Pycharm eats through changes like that, so I didn't want you to waste your time.