convexengineering / SPaircraft

Models for commercial aircraft design
http://spaircraft.readthedocs.org
25 stars 17 forks source link

tests fail sporadically #91

Closed whoburg closed 7 years ago

whoburg commented 7 years ago

Tests are currently failing, e.g.

Can @1ozturkbe and @mayork please make it a priority to get these passing?

1ozturkbe commented 7 years ago

Also, I'm not sure why this is, but those tests haven't been run in the last 12 days? How does one build?

mayork commented 7 years ago

@1ozturkbe i think we get a master that passes tests and then adjust the settings on this repo so it's like master in the fact someone has to approve all merges to master once tests are passing.

1ozturkbe commented 7 years ago

wait, is it possible that the tests aren't running because the repo name has changed? I would not be surprised, because usually pushes and pull requests should trigger jenkins.

mayork commented 7 years ago

@bqpd can you take a look at this? I made a number of pushes to this repo's master two days ago that didn't trigger any tests.

bqpd commented 7 years ago

sure thing!

bqpd commented 7 years ago

@galbramc, is https://acdl.mit.edu/csi/job/gpkit_ResearchModel_d8_Push/ no longer working with push triggers because the repository was renamed?

galbramc commented 7 years ago

yeah the rename would mess things up. I'll rename things in jenkins as well.

galbramc commented 7 years ago

test this please

galbramc commented 7 years ago

test this please

galbramc commented 7 years ago

test this please

galbramc commented 7 years ago

duh, this is an issue not a PR... jenkins wont test this...

galbramc commented 7 years ago

I think it is all fixed now, but I don't have a PR to test with.

mayork commented 7 years ago

I just pushed and the build is passing now so i'm going to close. @galbramc and @bqpd thanks for your help!