search

convexengineering / gpfit

Fit posynomials to data
http://gpfit.readthedocs.io/en/latest/
MIT License
10 stars 7 forks source link

Remove duplication of _Fit.params and _Fit.parameters #106

Open pgkirsch opened 3 years ago

pgkirsch commented 3 years ago

params is array, parameters is a dictionary, both have some value but the similar names are confusing.

whoburg commented 3 years ago

believe the parameters name came from Levenberg–Marquardt literature

pgkirsch commented 3 years ago

I figured there was a good precedent for it. My issue isn't with our use of parameters, rather that I clumsily introduced a new attribute parameters while we still also have params (the variable name that has been around since OG GPfit). Lazy on my part and needs to be deconflicted, just not sure how best to do it yet.

whoburg commented 3 years ago

gotcha, sounds good.