search

convexengineering / gpfit

Fit posynomials to data
http://gpfit.readthedocs.io/en/latest/
MIT License
10 stars 7 forks source link

Fit constraint set #71

Closed mjburton11 closed 7 years ago

mjburton11 commented 7 years ago

@bqpd I would like your feedback on this PR. Specifically, I would like your feedback on the following:

1) are the pylint disables OK 2) how do I find the path to a program like XFOIL? see xfoil_wrapper.py 3) I need help writing unit tests for fit_constraintset. I'm not sure where to start.

mjburton11 commented 7 years ago

@bqpd ready for review. Not to put any pressure, but I would like to get this merged pretty quickly if we can.

bqpd commented 7 years ago

Looks good to me; merge away!