Refactor goals - Githubissues

convexengineering / gpfit

Fit posynomials to data

http://gpfit.readthedocs.io/en/latest/

MIT License

10 stars 7 forks source link

Refactor goals #73

Open bqpd opened 7 years ago

bqpd commented 7 years ago

[ ] top-level support of Fit Constraint Sets
[ ] reduce the amount of code
[ ] be more consistent with numpy/scipy convention
- [ ] such as by having variables in different rows, not columns, or automatically transposing (https://github.com/hoburg/gpfit/issues/72)

pgkirsch commented 3 years ago

@bqpd what do you mean by top-level support? And is there a specific target you think should be achieved for code reduction?

bqpd commented 3 years ago

oh gosh. four years ago I think I meant...have ConstraintSets be the primary object that was interacted with? like, their constructors would be the fit-solving, they'd have ways to pickle/load/automatically recreate themselves?

re: code reduction I think I was mostly thinking of things like using scipy's LM, being stricter with input requirements to reduce casting (but adding error messages to tell users the right interface)

pgkirsch commented 3 years ago

Haha well remembered, thanks.